Skip to content

Conversation

@colonesej
Copy link
Contributor

Description

If you have an empty definition passed through a node kwargs , like pf.Task(name="t1", cron=None), pyflow raises AssertionError for no apparent reason. Here it will just ignore the cron definition and move on.

This allows more flexibility when changing the node properties depending on configuration more explicitly.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@colonesej colonesej requested a review from corentincarton July 30, 2025 13:33
@colonesej colonesej added the enhancement New feature or request label Jul 30, 2025
@corentincarton corentincarton merged commit 91da83f into develop Sep 4, 2025
7 checks passed
@corentincarton corentincarton deleted the feature/do_not_fail_when_empty_property branch September 4, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants